Review requested:

• @nodejs/build
• @nodejs/gyp
• @nodejs/security-wg
• @nodejs/tsc

@marco-ippolito do you know what steps are needed to run and expose Rust code just like C++?

@marco-ippolito do you know what steps are needed to run and expose Rust code just like C++?

its already done in this PR, see d9ee95f

basically add the crate in the deps/crates cargo.toml, create a header file if doesnt come with the crate and add it to the node gyp

Will this type strip at runtime? Or will it do it at build time?

Will this type strip at runtime? Or will it do it at build time?

Build time

How does this interact with the --node-builtin-modules-path flag? will it still type strip at runtime in that case?

How does this interact with the --node-builtin-modules-path flag? will it still type strip at runtime in that case?

Yes, I tested it, it works fine. it plugs in the js2c module

I'm relatively concerned about adding 1 million and 300 hundred thousand lines of code, even if they are just dependencies.

Is there a solution that does not require this much?

I dont think so since we are vendoring dependencies. I think the only solution is to have an automation generate them but its kinda impossible to review anyways. (The temporal PR from @legendecas had the same problem)

I think the question should be is it necessary to have every swc dependencies to be included?

I listed the newly added dependencies, and the followings are the biggest deps that I doubt if they are required:

9.6M	deps/crates/vendor/tracing          => Diagnostic purpose
5.1M	deps/crates/vendor/libc             => Indirect dep of crates `cpufeatures` and `num_cpus`
2.8M	deps/crates/vendor/regex-automata   => Regex engine
1.6M	deps/crates/vendor/bitvec           => Indirect dep of swc_sourcemap
1.6M	deps/crates/vendor/zerocopy         => Indirect dep of hashbrown
1.3M	deps/crates/vendor/zerocopy-derive  => Indirect dep of hashbrown
1.0M	deps/crates/vendor/idna             => Indirect dep of crate `url`

Additionally, crates like wasm-bindgen are not technically needed for the PR purpose.

I think technically many of these deps can be stripped down.

Can I just like delete them and see if it builds?

I tried to remove those crates but it seems they are all required to build. Idk if there is a way to know exactly which ones are unused or how to remove them, I'm no rust expert

This is blocked by nodejs/build#4245

Node.js configure: Found Python 3.12.3...
INFO: configure completed successfully
SKIP_XZ=1 supplied, skipping .tar.xz creation
mkdir -p out/doc
cp doc/node-config-schema.json out/doc
mkdir -p out/doc/api
cp -r doc/api out/doc

added 323 packages, and audited 325 packages in 6s

136 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
[09:05:04.899] ERROR: Unknown file extension ".wasm" for /home/runner/work/node/node/tools/doc/node_modules/@minify-html/wasm/index_bg.wasm
TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".wasm" for /home/runner/work/node/node/tools/doc/node_modules/@minify-html/wasm/index_bg.wasm
    at Object.getFileProtocolModuleFormat [as file:] (node:internal/modules/esm/get_format:189:9)
    at defaultGetFormat (node:internal/modules/esm/get_format:232:36)
    at defaultLoad (node:internal/modules/esm/load:145:22)
make: *** [Makefile:845: out/doc/api/addons.html] Error 1
    at async ModuleLoader.loadAndTranslate (node:internal/modules/esm/loader:543:45)

this seems unrelated but consistent 🫤

I'm relatively concerned about adding 1 million and 300 hundred thousand lines of code, even if they are just dependencies.

Is there a solution that does not require this much?

I had she same concern in another PR I was working on. (no spoiler ;P)
I wonder if it would make sense to track such deps in another repo or similar solutions.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.65%. Comparing base (3725bd2) to head (5c971a2).
⚠️ Report is 2 commits behind head on main.

@@            Coverage Diff             @@
##             main   #62146      +/-   ##
==========================================
- Coverage   89.65%   89.65%   -0.01%     
==========================================
  Files         676      675       -1     
  Lines      206543   206492      -51     
  Branches    39547    39532      -15     
==========================================
- Hits       185184   185133      -51     
+ Misses      13480    13474       -6     
- Partials     7879     7885       +6